search

MadLittleMods / postcss-css-variables

PostCSS plugin to transform CSS Custom Properties(CSS variables) syntax into a static representation
https://madlittlemods.github.io/postcss-css-variables/playground/
Other
536 stars 62 forks source link

Add basic postcss 8 support #129

Closed delucis closed 3 years ago

delucis commented 3 years ago

I’ve been using this branch by @larslaade for compatibility with postcss@^8 and it seems to work pretty well. Perhaps it would be good to merge it into the main package?

This would address #127.

https://evilmartians.com/chronicles/postcss-8-plugin-migration

MadLittleMods commented 3 years ago

Thanks @delucis! This looks like it's matching the migration guide ❤️ , https://evilmartians.com/chronicles/postcss-8-plugin-migration

delucis commented 3 years ago

Just in case my review comment got missed:

It looks like this is a hard break. I tried a minimal build task with postcss@^7 and this branch and got this error:

Error: PostCSS plugin postcss-css-variables requires PostCSS 8. Migration guide for end-users: https://github.com/postcss/postcss/wiki/PostCSS-8-for-end-users

MadLittleMods commented 3 years ago

Thanks for the poke on this @delucis! Merged and shipped in postcss-css-variables@0.18.0 🚀

Thanks for the contribution to bring us more up to date ❤