search

MadLittleMods / postcss-css-variables

PostCSS plugin to transform CSS Custom Properties(CSS variables) syntax into a static representation
https://madlittlemods.github.io/postcss-css-variables/playground/
Other
536 stars 62 forks source link

Fixed preserve option inside at-rules #43

Closed muftiev closed 7 years ago

muftiev commented 7 years ago

Fix #42

MadLittleMods commented 7 years ago

Thanks for the PR @muftiev :grinning:

Please add some tests that previously fail and now work

muftiev commented 7 years ago

Updated tests with new cases 😄

MadLittleMods commented 7 years ago

@muftiev Let's split those off into their own preserve-variables-in-media file

muftiev commented 7 years ago

Ok, done)

muftiev commented 7 years ago

@MadLittleMods Will you accept it? 😄

MadLittleMods commented 7 years ago

@muftiev Most likely, will try to get this in by Monday. Feel free to ping

muftiev commented 7 years ago

@MadLittleMods Ping to remind you to deal with this PR

muftiev commented 7 years ago

@MadLittleMods Really wish to use your module in my project, but I need this fix 😄

MadLittleMods commented 7 years ago

Sorry for the wait, I brushed across this tab in my browser everyday (on my mind).

@muftiev Thanks again for the contribution, I'll get this onto a release pronto.

muftiev commented 7 years ago

Thank you!

MadLittleMods commented 7 years ago

@muftiev v0.5.2 now pushed to npm, https://www.npmjs.com/package/postcss-css-variables

muftiev commented 7 years ago

Great! 😄