search

MadMG / moment-jdateformatparser

Translates the `java.text.SimpleDateFormat` date format to the `moment.js` date format.
MIT License
58 stars 29 forks source link

Update UMD support #12

Closed getfatday closed 7 years ago

getfatday commented 9 years ago

Update UMD support to address #11

herom commented 9 years ago

Hey @getfatday, thanks a lot for your contribution! :+1:

Although this PR is described as "Update UMD support" it looks more like a major rewrite of the whole thing. I'd like @MadMG to give his thoughts about it before we merge it - I hope you understand :smiley:

getfatday commented 9 years ago

@herom no problem. Let me know what you think.

herom commented 7 years ago

Closing because of too many changes (would be a complete rewrite which is not necessary in order to achieve the solution) and because of the (too long) time in between the opening of this PR and a clear decision. sorry.