MadNLP / DynamicNLPModels.jl

NLPModels for dynamic optimization
MIT License
11 stars 1 forks source link

Added support for off-diagonal S elements #18

Closed dlcole3 closed 2 years ago

dlcole3 commented 2 years ago

Added support to LQDynamicData and LQDynamicModel to handle non diagonal S matrix in the objective function. LQDynamicData now has an attribute for S, and LQDynamicModel now incorporates S into the construction of H for both sparse and condensed forms. Also updated sparse_lq_test.jl so that the JuMP formulation includes the S matrix and added a new test for the addition of the S matrix. Also changed type variable in source code so that it uses V in place of S (e.g., LQDynamicData{T, S, M} is now LQDynamicData{T, V, M}.

codecov-commenter commented 2 years ago

Codecov Report

Merging #18 (186a513) into main (1c82649) will increase coverage by 0.07%. The diff coverage is 97.50%.

@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
+ Coverage   93.95%   94.03%   +0.07%     
==========================================
  Files           1        1              
  Lines         331      352      +21     
==========================================
+ Hits          311      331      +20     
- Misses         20       21       +1     
Impacted Files Coverage Δ
src/DynamicNLPModels.jl 94.03% <97.50%> (+0.07%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1c82649...186a513. Read the comment docs.