search

MadNLP / DynamicNLPModels.jl

NLPModels for dynamic optimization
MIT License
11 stars 1 forks source link

Hessian bug fix #8

Closed dlcole3 closed 2 years ago

dlcole3 commented 2 years ago

Resolved the bug that resulted in regularizing a convex QP within MadNLP.jl.

LQDynamicModel included a $u_N$ variable that was not needed within the optimization problem. Removed this variable by removing empty row/column in Hessian and empty column in Jacobian and extra lines in lvar and uvar.

Also updated build_QP_JuMP_model function within sparse_lq_test.jl to remove the $u_N$ variable.

codecov-commenter commented 2 years ago

Codecov Report

Merging #8 (4e4a720) into main (23a7864) will not change coverage. The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main       #8   +/-   ##
=======================================
  Coverage   61.45%   61.45%           
=======================================
  Files           1        1           
  Lines         179      179           
=======================================
  Hits          110      110           
  Misses         69       69
Impacted Files Coverage Δ
src/DynamicNLPModels.jl 61.45% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 23a7864...4e4a720. Read the comment docs.