More concise constructor - Githubissues

MadNLP / DynamicNLPModels.jl

NLPModels for dynamic optimization

MIT License

11 stars 1 forks source link

More concise constructor #9

Closed sshin23 closed 2 years ago

sshin23 commented 2 years ago

For the constructor of DynamicNLPModels from A,B,Q,R,etc., (https://github.com/MadNLP/DynamicNLPModels.jl/blob/main/src/DynamicNLPModels.jl#L266) it is better to internally call the other constructor (https://github.com/MadNLP/DynamicNLPModels.jl/blob/main/src/DynamicNLPModels.jl#L178), to make the source code concise and make the future maintenance easier