MadNLP / MadNLP.jl

A solver for nonlinear programming
MIT License
160 stars 14 forks source link

Revisit fixed variables treatment #360

Open frapac opened 1 month ago

frapac commented 1 month ago

Solve #70, #229

Warning: this PR adds a small breaking change in create_kkt_system (we remove ind_cons from the arguments) but I think it's worth the change, as the previous situation was error prone. Now, we make sure we store all the problem's information inside the callback wrapper cb.

Preliminary results on space_shuttle_reentry shows that the current PR improves slightly the convergence (less iterations, less feasibility restoration), see the logs in attachment:

Benchmark on CUTEst is under way.

frapac commented 1 month ago

Results on CUTEst are out (comparing this PR with MadNLP 0.8.4). It looks like we just improve very slightly the total number of iterations. In terms of computation time, we are slower. Also we are less robust now than before. pprof-iter.pdf pprof-cpu.pdf

Currently investigating what's going on.

frapac commented 1 month ago

Benchmark is improved if we use the fix in #361 in this PR: pprof-cpu.pdf