search

MadStudioRoblox / ProfileService

Universal session-locked savable table API
https://madstudioroblox.github.io/ProfileService/
Apache License 2.0
292 stars 157 forks source link

Set `RobloxWriteCooldown` to `0` #37

Closed ghost closed 11 months ago

ghost commented 1 year ago

Roblox has recently removed the 6 second write interval cooldown per key for scalability, so this PR updates the RobloxWriteCooldown setting to 0 to avoid unnecessary cooldowns if any.

LM-loleris commented 11 months ago

Thank you for the pull request!

Even though, considering all the facts about Roblox data stores, a ProfileService DataStore call queueing system would become redundant after the 6 second cooldown is gone, there are still a lot of intricacies to Roblox data stores that are poorly documented or not documented at all (e.g. Trying to :UpdateAsync() the same key through multiple servers will make the calls take longer to finish due to it being an atomic read+write operation... What are the limits to this? How many different servers can call :UpdateAsync() on the same key before the functionality becomes unstable?) so some choices in ProfileService remain as purely precautionary due to lack of 100% understanding how DataStore works and potential future changes to how DataStore works.

Not much changes for ProfileService after removing the RobloxWriteCooldown, so it doesn't really matter for now.