search

MadaMzandu / uisp-ros-plugin

This is a follow up replacement for the previous Uisp api for mikrotik routers.
34 stars 9 forks source link

Broken since update to UISP 2.1.38 #34

Closed afrietaadmin closed 1 year ago

afrietaadmin commented 1 year ago

Hi

Upgraded to UISP 2.1.38 (Early access). There is mention in the release notes [https://community.ui.com/releases/UISP-2-1-38/5c628571-2a22-43fc-9c81-f355addb5919] that PHP has been updated to 8.1. and plugins need to be updated.

The plugin does not communicate with the routers as I no longer see any logins from UISP (user I have created on the MIkrotiks for this).

I have pulled this out out the webhook endpoint (http://localhost/crm/_plugins/ros-plugin/public.php) and hope this helps:


Warning: Undefined property: stdClass::$id in /data/ucrm/data/plugins/ros-plugin/lib/service_base.php on line 51
{"status":"failed","error":true,"message":"Sqlite3 error: Unable to prepare statement: 1, incomplete input"}

image

{ "error": { "code": 400, "message": "API key not valid. Please pass a valid API key.", "status": "INVALID_ARGUMENT", "details": [ { "@type": "type.googleapis.com/google.rpc.ErrorInfo", "reason": "API_KEY_INVALID", "domain": "googleapis.com", "metadata": { "service": "cloudbuild.googleapis.com" } } ] } }

MadaMzandu commented 1 year ago

Thanks for opening the issue. Will try to reproduce and find the cause, technically 8.1 should be backward compatible with 7.4 in most respects.

MadaMzandu commented 1 year ago

The plugin appears to have no problems running on php 8.1. However the webhooks sent by uisp are not complete and have null values. This why the plugin is not able to provision. Perhaps we should wait for another release, 2.1.38 appears to have a broken webhook feature.

https://community.ui.com/releases/UISP-2-1-38/5c628571-2a22-43fc-9c81-f355addb5919#comment/9f6d9c47-daa1-46e3-b93d-7266b2e04db1

MadaMzandu commented 1 year ago

Just to update on this it appears uisp version 2.2.5 has been released the issue has been fixed.

afrietaadmin commented 1 year ago

Thank you very much for your reply.

I was going to email you and advise the issue has been resolved. I have upgraded.

Thanks for your help and support.

Its nice dealing with you.

Regards Shahin

On Sat, 22 Apr 2023, 19:56 Madalitso Mzandu, @.***> wrote:

Just to update on this it appears uisp version 2.2.5 has been released the issue has been fixed.

— Reply to this email directly, view it on GitHub https://github.com/MadaMzandu/uisp-ros-plugin/issues/34#issuecomment-1518717108, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUQQGAWPBNM5ENT7YOI7VITXCQLULANCNFSM6AAAAAAWTSHVZY . You are receiving this because you authored the thread.Message ID: @.***>