search

MadaMzandu / uisp-ros-plugin

This is a follow up replacement for the previous Uisp api for mikrotik routers.
32 stars 9 forks source link

ROS Plugin not pulling Company Name from UISP #55

Closed afrietaadmin closed 1 year ago

afrietaadmin commented 1 year ago

Hi

Have noticed that ROS Plugin is not naming the queues and DHCP Leases when the customer is a Business/Company. Instead it uses Client .

Just a minor issue.

Thanks

MadaMzandu commented 1 year ago

Thanks for picking this up, its supposed to prefer the company name. I will review the code and fix for next release.

MadaMzandu commented 1 year ago

The code appears to prefer the company name, but will do some tests to see why this might be happening

dhanielsnieto commented 1 year ago

I just realized this error, and it is that when it is a company, it only uses "5180 - Client-XXXX - XXX" image

MadaMzandu commented 1 year ago

Thanks for extra feedback. I am working to resolve.

MadaMzandu commented 1 year ago

Have reupped version 2.0.2.11 with the fix. Problem is that its not caching company name.

After applying the fix - settings > cache button, then rebuild router. There will be a duplicate queue - delete the client-xx queue

MadaMzandu commented 1 year ago

This problem is more serious than first thought, also in the plugin's service listing the company name is not showing. also related if service is suspended a new queue with slightly different name is created.

MadaMzandu commented 1 year ago

Issues 55 & 54 have been properly resolved in 2.0.2.12. That's a lot of revisions, but we are not moving to 2.0.3 until all the small bugs from the "write engine" upgrade have been resolved. I think we are almost there.