search

MadaMzandu / uisp-ros-plugin

This is a follow up replacement for the previous Uisp api for mikrotik routers.
32 stars 9 forks source link

Serious Bug: creating a 1M queue on target 0.0.0.0/0 for archived subscriber #58

Closed afrietaadmin closed 11 months ago

afrietaadmin commented 1 year ago
Queues created incorrectly 1

This had the effect of dropping traffic for my entire subscriber subscriber base.

I can delete the queue and the moment I reenable the plugin, it will recreate the queue

MadaMzandu commented 1 year ago

Ok not a good one. Is the address pool okey? Why no address? I will check it and update you

afrietaadmin commented 1 year ago

Hi

Pool is fine. Both the subscribers were archived. So I dont know why it does this.

Thanks

On Mon, 04 Sept 2023, 08:20 Madalitso Mzandu, @.***> wrote:

Ok not a good one. Is the address pool okey? Why no address? I will check it and update you

— Reply to this email directly, view it on GitHub https://github.com/MadaMzandu/uisp-ros-plugin/issues/58#issuecomment-1704677595, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUQQGAQELDXKAFWMS5UD5FTXYVXLTANCNFSM6AAAAAA4JDVFGQ . You are receiving this because you authored the thread.Message ID: @.***>

MadaMzandu commented 12 months ago

I still cannot recreate this problem, but I will keep looking at the code, perhaps I will see something.

afrietaadmin commented 12 months ago

Hi

Check this

I created a queue using the rest api without specifying the target

[image: image.png]

When you open the specific queue, you can see the target is 0.0.0.0/0

[image: image.png]

And yes it is affecting traffic

[image: image.png]

what you need to ask is why is the code acting upon services where client is archived and then restored for administrative purposes. UISP only allows you to look at data when a client is restored. we often remove the IP address from the IP Address as was the case. Check if your code is creating a queue with a target unspecified because in the Mikrotik unspecified defaults to 0.0.0.0/0

hope this helps.

On Sat, Sep 16, 2023 at 5:03 PM Madalitso Mzandu @.***> wrote:

I still cannot recreate this problem, but I will keep looking at the code, perhaps I will see something.

— Reply to this email directly, view it on GitHub https://github.com/MadaMzandu/uisp-ros-plugin/issues/58#issuecomment-1722248615, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUQQGAXLC7AI32677MK37R3X2W5TVANCNFSM6AAAAAA4JDVFGQ . You are receiving this because you authored the thread.Message ID: @.***>

MadaMzandu commented 12 months ago

Thanks for the update, now that makes sense. When the client is restored uisp sends a trigger to re-create the account.

I guess the problem here is that the plugin is creating an account when the service has no ip address. I will check and correct.

MadaMzandu commented 12 months ago

I have upped version 2.0.2.19 which attempts to skip creating the account if an ip address is not available. I think this should solve the problem

afrietaadmin commented 12 months ago

Thanks Bro

On Mon, 18 Sept 2023, 16:18 Madalitso Mzandu, @.***> wrote:

I have upped version 2.0.2.19 which attempts to skip creating the account if an ip address is not available. I think this should solve the problem

— Reply to this email directly, view it on GitHub https://github.com/MadaMzandu/uisp-ros-plugin/issues/58#issuecomment-1723522233, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUQQGAQTRSBENN5SCIDVGZDX3BJ37ANCNFSM6AAAAAA4JDVFGQ . You are receiving this because you authored the thread.Message ID: @.***>