MadaMzandu / uisp-ros-plugin

This is a follow up replacement for the previous Uisp api for mikrotik routers.
34 stars 9 forks source link

Changing ppoe username/password/IP requires manual cache rebuild #61

Open jirkaehm opened 10 months ago

jirkaehm commented 10 months ago

Hi,

First of all, thank you for an amazing project, it does almost exactly what I need. Sended first bunch of coffes in testing phase ;-)

I have an issue when I change PPoE client IP address OR login.

In order to get it propagated to Mikrotik, I need to go to plugin > Settings> System > click rebuild cache and then rebuild.

Until then, it synces old settings that is no more set on customer.

Is it normal behaviour, or I'm doing something wrong?

Thank you!

P.S: Have you thought about cleaning up old renamed/deleted accounts from Mikrotik? Would propably require some custom text in comment so you can identify that account was created by this project... I can take a look at it (not a good programmer), just asking if someone thought about it.

MadaMzandu commented 9 months ago

Sorry for delayed response - holiday season. Are you on the latest version?

The rebuild works from cache, I will check if this is being updated correctly otherwise that could result in what you are experiencing.

And thanks for the kofis.

MadaMzandu commented 9 months ago

Problem has been found - the cache is not being updated when a service is deleted. Will make a fix for next release.

As for the clean up, what I can do is generate a list of orphan accounts, then you can manually select the ones to delete. This will be safer, I will add the suggestion as a feature request.