Hi, thanks a lot for the plugin and examples! I just started to study module federation and your repository help me understand it better as my background is mainly Rollup and Vite.
This is a quick question about the error logs in demo. This was probably intended to be solved by your PR on upstream https://github.com/module-federation/core/pull/2753, but it appears that it stills has an issue on latest runtime v0.5.1, which I'm testing locally.
After some digging, it looks like there are two issues:
your PR added a new condition for remoteInfo.type === "module", but rollup plugin's remote entry manifest has "type": "esm", so it's still missing the condition.
@hi-ogawa Thanks for reporting this issue. I think you are right and the issue is still in https://github.com/module-federation/core. I'll try to send a PR to fix it.
Hi, thanks a lot for the plugin and examples! I just started to study module federation and your repository help me understand it better as my background is mainly Rollup and Vite.
This is a quick question about the error logs in demo. This was probably intended to be solved by your PR on upstream https://github.com/module-federation/core/pull/2753, but it appears that it stills has an issue on latest runtime v0.5.1, which I'm testing locally.
After some digging, it looks like there are two issues:
remoteInfo.type === "module"
, but rollup plugin's remote entry manifest has"type": "esm"
, so it's still missing the condition."type": "module"
, the runtime is still forcingtext/javascript
https://github.com/module-federation/core/blob/865c00bc542e904e24fbcc58c0bb0ec9c8a68c7a/packages/sdk/src/dom.ts#L50-L80I think these are still core issues, but I'm far from being able to provide reproduction for core, so I'm writing a report here first.