search

MadcapJake / fly-notify

Native notifications for Fly.
Other
7 stars 1 forks source link

Message isn't being set by default #3

Closed rogeruiz closed 9 years ago

rogeruiz commented 9 years ago

The documentation gives an example to add options by passing in a POJO to the notify method.

   .notify({
      title: "Fly Default",
      message: "Completed default task", // This line in particular
      icon: "dev:code_badge"
    })

I didn't have any luck until I cracked open the code here, and saw the assignment order here

    notifier.notify(assign(options, { // `options` argument is first so it's content will be ovewritten.
      title: "Fly",
      message: "Task completed.",
      icon: options.icon
        ? devicon(options.icon)
        : path.join(__dirname, "fly-logo.png")
    }),

I'd like to submit a patch updating this. I know the project is pretty new so I wanted to make sure I wasn't stepping on any toes. Let me know and I'll submit a PR.

MadcapJake commented 9 years ago

No worries! No toes stepped on here! :stuck_out_tongue_closed_eyes:

rogeruiz commented 9 years ago

Cool. I'll submit this later tonight for review. thanks! :+1: