search

MaddTheSane / SVGKit

A Cocoa framework for rendering SVG files as Core Animation layers
http://mattrajca.com
Other
47 stars 19 forks source link

(incomplete) Lumberjack 2.x for mts's fork of svgkit #12

Closed seltzered closed 9 years ago

seltzered commented 9 years ago

Hey, this is still a work in progress (and now not automatically merge-able) but wanted to let you know about it.

I was able to get osx demos and demo-ios to work but ran into issues when building the "svgkit-ios framework" (the library version built okay). at the time I was stuck at a compiler error resulting in this:

screen shot 2014-12-21 at 8 28 21 pm

Then got sick this past week and haven't had time to finish this migration. Just wanted to let you know since I just noticed your commits earlier this week preparing for CL 2.x changes.

One more thing: You probably shouldn't merge this. This branch temporarily commented out your work in setting up an 'internal log level'.

MaddTheSane commented 9 years ago

There seems to be the occasional issue when building a framework and a static library version of the same library, as it mixes which physical header should be included. I found that cleaning the static library can help, but if that doesn't, then going into the built products directory and deleting the header files is necessary.

Sent from my iPad

On Dec 21, 2014, at 9:36 PM, Vivek Gani notifications@github.com wrote:

Hey, this is still a work in progress (and now not automatically merge-able) but wanted to let you know about it.

I was able to get osx demos and demo-ios to work but ran into issues when building the "svgkit-ios framework" (the library version built okay). at the time I was stuck at a compiler error resulting in this:

Then got sick this past week and haven't had time to finish this migration. Just wanted to let you know since I just noticed your commits earlier this week preparing for CL 2.x changes.

You can merge this Pull Request by running

git pull https://github.com/seltzered/SVGKit Lumberjack-2.x-svgkit-MTSfork Or view, comment on, or merge it at:

https://github.com/MaddTheSane/SVGKit/pull/12

Commit Summary

Breaking: Removing old Lumberjack Installing CocoaLumberjack via git read-tree, up to commit tagged 2.0.0-beta4. Specifically, I did these steps: Installing CocoaLumberjack (Framework) via git read-tree, up to commit tagged 2.0.0-beta4, because the framework builds are split depending on platform (OS X vs. ios) Specifically, I did these steps: Project-file updates to use updated lumberjack framework, just thinking about the OS X demo for now. renaming to Lumberjack to CocoaLumberjack in pch renaming DDLogC methods to DDLog, see cocoa lumberjack issue #220 for why this is okay. rename of cocoalumberjack flag_info reference to lumberjack 2.x term removing old lumberjack reference, should be referenced via pch file hack: temporarily commenting out the internal log-level setting feature minor, marking 'private' headers as private within OS X framework target build. This was an attempt to mitigate the intermitten build errors where "Duplicate Interface Definitions" occur.. rename of lumberjack header import in iOS pch file project changes to make lumberjack work, essentially I dragged in the lumberjack framework projects (there's different ones for desktop & mobile) in the svgkit workspace. adding a deployment target minimum version for the ios demo, not exactly sure why I did this. adding libCocoaLumberjack to be linked in the svgkit ios framework, but seems to be duplicated from two commits earlier. build of 'svgkit-ios framework' still broken File Changes

M Demo-OSX.xcodeproj/project.pbxproj (15) M Demo-iOS.xcodeproj/project.pbxproj (60) M SVGKit.xcodeproj/project.pbxproj (402) M Source/AppKit additions/SVGKImageRep.m (1) M Source/DOM classes/SVG-DOM/SVGHelperUtilities.m (2) M Source/Parsers/SVGKParser.m (12) M Source/Parsers/SVGKPointsAndPathsParser.m (8) M Source/SVGKImage.m (4) M Source/SVGKit.h (30) M Source/SVGKit.m (350) M Source/SVGKit_logging.pch (23) M Source/Unsorted/SVGUtils.m (6) A Source/Vendor/CocoaLumberjack/Classes/CLI/CLIColor.h (28) A Source/Vendor/CocoaLumberjack/Classes/CLI/CLIColor.m (55) A Source/Vendor/CocoaLumberjack/Classes/CocoaLumberjack.h (81) A Source/Vendor/CocoaLumberjack/Classes/CocoaLumberjack.swift (96) A Source/Vendor/CocoaLumberjack/Classes/DDASLLogCapture.h (32) A Source/Vendor/CocoaLumberjack/Classes/DDASLLogCapture.m (221) A Source/Vendor/CocoaLumberjack/Classes/DDASLLogger.h (42) A Source/Vendor/CocoaLumberjack/Classes/DDASLLogger.m (116) R Source/Vendor/CocoaLumberjack/Classes/DDAbstractDatabaseLogger.h (89) A Source/Vendor/CocoaLumberjack/Classes/DDAbstractDatabaseLogger.m (660) A Source/Vendor/CocoaLumberjack/Classes/DDAssertMacros.h (26) R Source/Vendor/CocoaLumberjack/Classes/DDFileLogger.h (262) A Source/Vendor/CocoaLumberjack/Classes/DDFileLogger.m (1512) A Source/Vendor/CocoaLumberjack/Classes/DDLegacy.h (68) A Source/Vendor/CocoaLumberjack/Classes/DDLog+LOGV.h (79) R Source/Vendor/CocoaLumberjack/Classes/DDLog.h (582) A Source/Vendor/CocoaLumberjack/Classes/DDLog.m (1108) A Source/Vendor/CocoaLumberjack/Classes/DDLogMacros.h (77) A Source/Vendor/CocoaLumberjack/Classes/DDTTYLogger.h (172) A Source/Vendor/CocoaLumberjack/Classes/DDTTYLogger.m (1476) A Source/Vendor/CocoaLumberjack/Classes/Extensions/DDContextFilterLogFormatter.h (69) A Source/Vendor/CocoaLumberjack/Classes/Extensions/DDContextFilterLogFormatter.m (191) R Source/Vendor/CocoaLumberjack/Classes/Extensions/DDDispatchQueueLogFormatter.h (99) A Source/Vendor/CocoaLumberjack/Classes/Extensions/DDDispatchQueueLogFormatter.m (247) A Source/Vendor/CocoaLumberjack/Classes/Extensions/DDMultiFormatter.h (36) A Source/Vendor/CocoaLumberjack/Classes/Extensions/DDMultiFormatter.m (141) A Source/Vendor/CocoaLumberjack/Framework/Desktop/FmwkTest/AppDelegate.h (8) A Source/Vendor/CocoaLumberjack/Framework/Desktop/FmwkTest/AppDelegate.m (23) A Source/Vendor/CocoaLumberjack/Framework/Desktop/FmwkTest/FmwkTest-Info.plist (34) A Source/Vendor/CocoaLumberjack/Framework/Desktop/FmwkTest/FmwkTest-Prefix.pch (7) A Source/Vendor/CocoaLumberjack/Framework/Desktop/FmwkTest/en.lproj/Credits.rtf (29) R Source/Vendor/CocoaLumberjack/Framework/Desktop/FmwkTest/en.lproj/InfoPlist.strings (0) A Source/Vendor/CocoaLumberjack/Framework/Desktop/FmwkTest/en.lproj/MainMenu.xib (4582) A Source/Vendor/CocoaLumberjack/Framework/Desktop/FmwkTest/main.m (14) A Source/Vendor/CocoaLumberjack/Framework/Desktop/Lumberjack.xcodeproj/project.pbxproj (1024) A Source/Vendor/CocoaLumberjack/Framework/Desktop/Lumberjack.xcodeproj/xcshareddata/xcschemes/CocoaLumberjack.xcscheme (77) A Source/Vendor/CocoaLumberjack/Framework/Desktop/Lumberjack.xcodeproj/xcshareddata/xcschemes/CocoaLumberjackSwift.xcscheme (77) A Source/Vendor/CocoaLumberjack/Framework/Desktop/Lumberjack.xcodeproj/xcshareddata/xcschemes/FmwkTest.xcscheme (86) A Source/Vendor/CocoaLumberjack/Framework/Desktop/Lumberjack.xcodeproj/xcshareddata/xcschemes/Lumberjack (OS X/ iOS 8+).xcscheme (68) A Source/Vendor/CocoaLumberjack/Framework/Desktop/Lumberjack.xcodeproj/xcshareddata/xcschemes/SwiftTest.xcscheme (86) A Source/Vendor/CocoaLumberjack/Framework/Desktop/Lumberjack.xcodeproj/xcshareddata/xcschemes/iOSSwift.xcscheme (110) R Source/Vendor/CocoaLumberjack/Framework/Desktop/Lumberjack/CocoaLumberjack-Info.plist (2) R Source/Vendor/CocoaLumberjack/Framework/Desktop/Lumberjack/CocoaLumberjack-Prefix.pch (5) A Source/Vendor/CocoaLumberjack/Framework/Desktop/Lumberjack/CocoaLumberjack.modulemap (31) A Source/Vendor/CocoaLumberjack/Framework/Desktop/Lumberjack/CocoaLumberjackSwift-Info.plist (28) A Source/Vendor/CocoaLumberjack/Framework/Desktop/SwiftTest/AppDelegate.swift (46)
A Source/Vendor/CocoaLumberjack/Framework/Desktop/SwiftTest/Images.xcassets/AppIcon.appiconset/Contents.json (58) A Source/Vendor/CocoaLumberjack/Framework/Desktop/SwiftTest/Info.plist (32) A Source/Vendor/CocoaLumberjack/Framework/Desktop/iOSSwift/AppDelegate.swift (72)
A Source/Vendor/CocoaLumberjack/Framework/Desktop/iOSSwift/Formatter.swift (46) A Source/Vendor/CocoaLumberjack/Framework/Desktop/iOSSwift/Images.xcassets/AppIcon.appiconset/Contents.json (68) A Source/Vendor/CocoaLumberjack/Framework/Desktop/iOSSwift/Info.plist (45) A Source/Vendor/CocoaLumberjack/Framework/Desktop/iOSSwift/ViewController.swift (25) A Source/Vendor/CocoaLumberjack/Framework/Lumberjack.xcworkspace/contents.xcworkspacedata (13) A Source/Vendor/CocoaLumberjack/Framework/Mobile/LibTest/AppDelegate.h (11) A Source/Vendor/CocoaLumberjack/Framework/Mobile/LibTest/AppDelegate.m (41) A Source/Vendor/CocoaLumberjack/Framework/Mobile/LibTest/Base.lproj/Main_iPad.storyboard (30) A Source/Vendor/CocoaLumberjack/Framework/Mobile/LibTest/Base.lproj/Main_iPhone.storyboard (30) A Source/Vendor/CocoaLumberjack/Framework/Mobile/LibTest/Formatter.h (5) A Source/Vendor/CocoaLumberjack/Framework/Mobile/LibTest/Formatter.m (46) A Source/Vendor/CocoaLumberjack/Framework/Mobile/LibTest/Images.xcassets/AppIcon.appiconset/Contents.json (53) A Source/Vendor/CocoaLumberjack/Framework/Mobile/LibTest/Images.xcassets/LaunchImage.launchimage/Contents.json (51) A Source/Vendor/CocoaLumberjack/Framework/Mobile/LibTest/LibTest-Info.plist (49) A Source/Vendor/CocoaLumberjack/Framework/Mobile/LibTest/LibTest-Prefix.pch (16) A Source/Vendor/CocoaLumberjack/Framework/Mobile/LibTest/ViewController.h (6) A Source/Vendor/CocoaLumberjack/Framework/Mobile/LibTest/ViewController.m (6) A Source/Vendor/CocoaLumberjack/Framework/Mobile/LibTest/en.lproj/InfoPlist.strings (2) A Source/Vendor/CocoaLumberjack/Framework/Mobile/LibTest/main.m (18) A Source/Vendor/CocoaLumberjack/Framework/Mobile/Lumberjack.xcodeproj/project.pbxproj (583) A Source/Vendor/CocoaLumberjack/Framework/Mobile/Lumberjack.xcodeproj/xcshareddata/xcschemes/LibTest.xcscheme (110) A Source/Vendor/CocoaLumberjack/Framework/Mobile/Lumberjack.xcodeproj/xcshareddata/xcschemes/Lumberjack (Mobile).xcscheme (68) A Source/Vendor/CocoaLumberjack/Framework/Mobile/Lumberjack/Lumberjack-Prefix.pch (9) D Source/Vendor/Lumberjack/DDASLLogger.h (41) D Source/Vendor/Lumberjack/DDASLLogger.m (99) D Source/Vendor/Lumberjack/DDAbstractDatabaseLogger.m (728) D Source/Vendor/Lumberjack/DDFileLogger.m (1353) D Source/Vendor/Lumberjack/DDLog.m (1098) D Source/Vendor/Lumberjack/DDTTYLogger.h (167) D Source/Vendor/Lumberjack/DDTTYLogger.m (1490) D Source/Vendor/Lumberjack/Extensions/ContextFilterLogFormatter.h (65) D Source/Vendor/Lumberjack/Extensions/ContextFilterLogFormatter.m (191) D Source/Vendor/Lumberjack/Extensions/DispatchQueueLogFormatter.m (251) D Source/Vendor/Lumberjack/Extensions/README.txt (7) D Source/Vendor/Lumberjack/Lumberjack.h (10) M XCodeProjectData/SVGKit-OSX/SVGKit-OSX-Prefix.pch (2) M XCodeProjectData/SVGKit-iOS/SVGKit-iOS-Prefix.pch (2) Patch Links:

https://github.com/MaddTheSane/SVGKit/pull/12.patch https://github.com/MaddTheSane/SVGKit/pull/12.diff — Reply to this email directly or view it on GitHub.

seltzered commented 9 years ago

Whoa, deleting the build folder (and building the ios framework as the first step afterward) fixed it. Thanks! I'll go through it again and make a cleaner pull request this week. I may just need some help understanding your intentions in the setRawLogLevel stuff then.

MaddTheSane commented 9 years ago

+setRawLogLevel is supposed to take a value from DDLogLevelFlag, as opposed to +setLogLevel, which only takes SVGKLoggingLevel. SVGKLoggingLevel is supposed to match DDLogLevel, without having to include the CocoaLumberjack headers.