search

MaddTheSane / Simple-Comic

macOS comic viewer
MIT License
261 stars 23 forks source link

Cannot change full screen background color. #103

Closed ghost closed 1 year ago

ghost commented 1 year ago

On version 1.9.7 full screen background color is not able to be modified in the settings there seems to be a bug.

When I download 1.9.6 this issue was not there.

Attmped remedies:

Environment: Simple Comic 1.9.7 MacBook Air M2 MacOS 13.3.1

Boognoss commented 1 year ago

Same issue for me on similar hardware.

Simple Comic 1.9.7 Mac mini M1 / Mac mini M2 Both systems running MacOS 13.4

Regardless of what colour is selected, it stays white when in full screen.

waaykool commented 1 year ago

Same here. Simple Comic 1.9.7 iMac Intel, Ventura 13.3.1

Only white background in full screen.

Edit: This feature works as expected using Simple Comic 1.9.6

Edit#2: I am able to set a new background color within settings using Simple Comic vers 1.9.6. If I then quit 1.9.6, and re-open 1.9.7, Simple Comics 1.9.7 will display background color as previously set in 1.9.6 - but will then not be able to change that color from within 1.9.7. (So if I set a black background in 1.9.6, then 1.9.7 will open with a black background that can't be changed within 1.9.7).

MaddTheSane commented 1 year ago

My guess is I went into a modernize phase and didn't use the correct decoder function, so I just reverted it to use the older behavior.

The next release should fix this issue.

nickv2002 commented 11 months ago

BTW, I'll plan to update this soon. Haven't pushed an update yet because there were some Xcode issues this fall that I didn't have time to work around.

nickv2002 commented 11 months ago

I think this is fixed in the https://github.com/MaddTheSane/Simple-Comic/releases/tag/App-Store-1.9.8

LMK if otherwise

waaykool commented 11 months ago

Yes! This does work as expected now. Thanks for keeping me in mind!

 On Sunday, December 31, 2023 at 10:47:00 AM PST, Nick Vance ***@***.***> wrote:

I think this is fixed in https://github.com/MaddTheSane/Simple-Comic/releases/tag/App-Store-1.9.8

LMK if otherwise

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>