search

MaddieM4 / pymads

A fork of the pymds authoritative DNS server, designed for asynchronous lookup without domain restrictions.
GNU Lesser General Public License v3.0
4 stars 2 forks source link

Proper logging support ($50) #34

Closed MaddieM4 closed 11 years ago

MaddieM4 commented 11 years ago

Right now logging is all-or-nothing and involves print statements. Yikes. We gotta replace all that crap with the standard logging module.

MaddieM4 commented 11 years ago

Bounty is $50.

http://www.freedomsponsors.org/core/issue/299/proper-logging-support

(Copied from acceptance criteria)

Replace pretty much all calls to print() with the appropriate logging functions, using the standard logging module. If you find any instances you think should be exceptions to the barbarian gutting, ask in the Github issue comments.

As for the debug option, you can either retain that in some way and make it control log sensitivity, or completely deprecate it. Up to you, based on what makes more sense when interacting with the logging module. If I was familiar enough with its pointlessly byzantine architecture to care, I'd be doing it myself, instead of making a bounty for it.

pczarn commented 11 years ago

I'll do it since nobody else is going to.

I see only three calls to print() and one print_exception().

vivorisataamore commented 11 years ago

@campadrenalin have you tried putting a bounty on this on Bountysource? https://www.bountysource.com/issues/823113-proper-logging-support-50

MaddieM4 commented 11 years ago

@vivorisataamore No, I don't use Bountysource, but I'll consider it for future use. This particular bug looks like it's already attracted developer attention, so I'm not worried about it, but I'll look into BS next time I add a bounty to an issue.