search

MaddieM4 / pymads

A fork of the pymds authoritative DNS server, designed for asynchronous lookup without domain restrictions.
GNU Lesser General Public License v3.0
4 stars 2 forks source link

Cache filter doesn't respect TTL #39

Closed pczarn closed 10 years ago

pczarn commented 11 years ago

It will keep records indefinitely.

Filters are confusing: cache_filter.source is assigned from a chain. Source is a generator, not a source.

MaddieM4 commented 11 years ago

First one is a legit problem, second is by design.

The cache is exactly the sort of use case why get_from_sources() returns a generator. Theoretically, the filter has control of how many records to pull from its sources. In the case of the cache filter, if it already has all the information it needs in self.cache, then it can save you from incurring a recursive request at all.

That isn't really tested in practice, and it's very probable that the recursive request happens anyways, but that would be a bug, just not an urgent one (a lack of optimization rather than an error).