Maddoc42 / Android-Material-Icon-Generator

Android icons with looooong material shadows!
https://android-material-icon-generator.bitdroid.de/
Other
769 stars 66 forks source link

Real svg #13

Open Agshin43 opened 8 years ago

Agshin43 commented 8 years ago

I cant create icon from custom svg. It says upload real svg. I downloaded from https://design.google.com/icons/ and it says same.

Maddoc42 commented 8 years ago

Hey @Agshin43, thanks for the feedback. Could you please provide the following to narrow down the issue:

Agshin43 commented 8 years ago

Of course

Svg file `

<path d="M0 0h24v24H0z" fill="none"/>

`

Browser Safari Version 9.1.1 (11601.6.17)

Operating System OSX El Capitan Version 10.11.15

Maddoc42 commented 8 years ago

That's odd, the code at the point doesn't really do anything other than pass the file to the SVG library (paper.js), which returns undefined in case the file wasn't a valid SVG file (source).

Can you try a couple of more things?

Agshin43 commented 8 years ago

Sory for bad english ) Ok. I can not upload here SVG file. SVG not supported for uploading here. Yes, it works when I pick grade (star) from your site (https://android-material-icon-generator.bitdroid.de/). But https://design.google.com/icons/#ic_grade not working on OSX - safari. Now I trying on Windows - Chrome it works properly. Yes paper.js example shows star on windows - chrome. For now I am not able to check it OSX-safari. Thank you. It is really very good tool for creating Material Design Icons.

Maddoc42 commented 8 years ago

Thanks for testing that.

Once you have had the change to test the paper.js link on Safari please report back. In the meantime, GitHub issues seem to support .zip files. Could you upload the icon via that?

Agshin43 commented 8 years ago

Ok. This is grade (star) icon. ic_grade_black_24px-2.svg.zip. Paper.js displays star icon but when drag and drop ic_grade_black_24px-2.svg to your page it says "Invalid SVG file" on OSX Safari. But on windows 10 chome it works properly

Maddoc42 commented 8 years ago

Thanks again for reporting back. So far my theory that there might be a problem with actually interpreting the SVG file does not seem to add up. Looking at the code, there might also be an issue with actually reading the file before passing it to paper.js.

I have deployed a version which contains some debug outputs. Could you try your icon again and report back with the console output?

Maddoc42 commented 8 years ago

Hey @Agshin43, were you able to resolve your problem :grey_question: