Add banner

[kornfleks]

Hello :),

Just add "beta" banner. In the future I will add "dev" & "alpha" banner, and fix the position.

[Maddoc42]

Two general things:

• The tests are failing (you can run them locally, see the README for instructions)
• You probably forgot to add the Banner.js (presumably why the tests are failing?)

More specific to your changes: I like the general idea of adding a short side banner to the icon. Here are some things that would have to happen though before I will publish those changes on the main branch:

• Ability to customize banner background color
• Ability to customize banner text color
• Ability to somehow "collapse" all those options such that they don't take up too much space

Does this sound reasonable?

That being said I won't merge this into master now, but I am willing to keep reviewing changes and help where I can :)

[kornfleks]

Yes you are right I have forgottent Banner.js (but the test fail again, why ?). I will do a new pull request when your request features (Goods ideas :+1:) will be added.

I'm motivated by this project, great job ! (My english isn't perfect, sorry)

[kornfleks]

Can you give me some tips, I don't know why my code don't pass the tests :/.

[Maddoc42]

Glad to hear you're motivated!

Just did a clone of your changes, have you tried exporting the icons locally? That long works which is also the reason why the test cases fail.

In your first commit you (presumably accidentally) removed the following line from the editor.static.jade

canvas#canvas-export-playstore-icon

That cause the error you are seeing.

[kornfleks]

So I add this features :

• Ability to customize banner background color
• Ability to customize banner text color
• Ability to somehow "collapse" all those options such that they don't take up too much space

The collapse sub menu isn't perfect, but I don't want touch too much of your css right now. Perhaps you will find a good looking solution based on my work.

So I have some other ideas :

• Ability to customize width of banner
• Ability to customize the text of banner (small text, 6 charac. max ?)
• Ability to customize position X of banner

PS: thanks for your help with your code, I have tried to follow your tips best I can :+1:

[Maddoc42]

Nice, it's starting to come along! Couple of things I noticed:

• The hover effect on the banner setting entries is applied to all field instead of just one (hover over "Banner text color" will highlight all banner options)
• Padding between banner options is different than padding between other options
• Banner options are not restored when going back and selecting another icon (1. select icon 2. select beta 3. back 4. select another icon 5. beta is still enabled but not shown)

In addition here are some more suggestions:

• Can you move the banner options to the bottom, below the "Icon size"?
• Maybe always show the toggle buttons for Banner ("None", "Beta") and only if Beta is selected show the rest
• Any chance we can have a little expand anim when beta is toggled? ;)

Please feel free to change the css. I'm pretty new to it, so there a probably lot's of ways to make it better.

Thanks for all the hard work so far!

[kornfleks]

The test failed because of a 403 error ^^.

Your six demands has been granted :). I see only one bad behaviour, but I don't really know how to fix it properly. When you expand the banner sub-menu the scroll-bar doesn't go to the bottom :/.

In addition, the mouse wheel, to scroll the menu, isn't supported.

[Maddoc42]

Awesome :) thanks for the pull request. I'll look into the remaining issues and publish the result once those are fixed. Really great work!

[kornfleks]

Thanks you ! It's a pleasure to work with you :+1:

[Maddoc42]

Changes are live now. Banner looks really great. Thanks again :)