MadeBaruna / paimon-moe

Your best Genshin Impact companion! Help you plan what to farm with ascension calculator and database. Also track your progress with todo and wish counter.
https://paimon.moe
MIT License
1.38k stars 266 forks source link

BUG: Characters without existing builds does not load constellations #466

Closed jogerj closed 1 month ago

jogerj commented 11 months ago

Currently Neuvillette doesn't have any (placeholder) builds in data/build.js

When the character page is opened, it returns null at line 236 of [id].svelte so await getConstellationCount() is never called

It also has a side-effect that modifying the character constellation count deletes other characters constellation counts, as the original constellation count was never loaded.

The quickest fix would be adding the necessary data placeholder, but a proper fix would be to decouple loading build and constellation count (or handling null values)

neuvillette: {
    roles: {
      TBD: {
        recommended: false,
        weapons: [],
        artifacts: [],
        mainStats: {
          sands: ['TBD'],
          goblet: ['TBD'],
          circlet: ['TBD'],
        },
        subStats: ['TBD'],
        talent: ['TBD'],
        note: 'TBD',
      },
    },
  }
notstew commented 11 months ago

Kirara also suffers from this, a fix would be nice. Just had all my constellations reset in the character screen when tweaking Neuvillette.

hellridergit commented 11 months ago

People report Wriothesley too, and they also report loss of data in the JSON file (probably helped it). Either way it's a critical bug that breaks the site and should be addressed promptly.

TimEtOff commented 9 months ago

Same issue happen with Furina and Charlotte.

jogerj commented 1 month ago

should be fixed by f73d65dc8fb1d9f3ce38114fd1deb604c0705a7c