MadeBaruna / paimon-moe

Your best Genshin Impact companion! Help you plan what to farm with ascension calculator and database. Also track your progress with todo and wish counter.
https://paimon.moe
MIT License
1.41k stars 270 forks source link

Duplicate Achievement entries and off 1 Primogem Achievement entries #488

Open HonkySora opened 1 year ago

HonkySora commented 1 year ago

All of these are located under the "Wonders of the World" achievement category.

  1. Semnai Sans Shadow - This Achievement is already listed under "Fontaine: Dance of the Dew-White Springs (III)" for 10 Primogems. The one in the "Wonders of the World" is a duplicate, only listed for 1 Primogem (66 Mora in HoneyHunterWorld's database). I can also attest this achievement only triggered once in-game, under the Fontaine category.
  2. Deianeira of Snezhevna - This Achievement appears twice in "Wonders of the World" for the same 5 Primogem reward.
  3. Gentle Descent - This does not exist. I've been using the Ball Octopus abilities for some time now, and the achievement should have already triggered already according to the hint. Also listed for 1 Primogem (66 Mora in HoneyHunterWorld's database)
  4. Measure of Interference - Either this doesn't exist, or is a preload for a future achievement. Also listed for 1 Primogem (66 Mora in HoneyHunterWorld's database)

For more info, SoraHoshina has already started a list of v4.2 Wonder of the World achievements and all of the 1 Primogem achievements are not there. There is also just 1 instance of Deianeira of Snezhevna. v4.2 Hidden Achievement Guide

greyliances commented 1 year ago

Supersedes #485 (closed) and #487 (will close)

mrkswl commented 1 year ago

For those who will be fixing - of the two achievements "Deianeira of Snezhevna" you need to remove the first one (the top one in the list), based on the order of display in the game

HaoboZ commented 11 months ago

Is this planning to be fixed anytime soon?

WMGameLive commented 11 months ago

why does it take so long to fix?

N1klot commented 11 months ago

a whole patch later still no fix for a seemingly simple error...

selgalad commented 11 months ago

Waiting for this to be fixed. Yes, it's not that much of an important bug in the grand scale but it's extremely annoying to see them in the achievement checklist since they disturb the purpose of it.

alaya233 commented 10 months ago

怎么还没修复

Deses commented 10 months ago

Why it's taking so long to delete some rows on a database?

121Dev121 commented 10 months ago

is paimon.moe dead or dying?

leeonet123 commented 10 months ago

Untitled One duplicate and three Doesn't really exist

HaoboZ commented 9 months ago

Welp, I guess this is never gonna be fixed

Deses commented 9 months ago

I can't fucking believe they added the 4.4 achievements but they didn't fix this. How useless can you be?

I'm using https://genshin-center.com/achievements?cat=0 from now on.

N1klot commented 9 months ago

Same, moved on to genshin center. It's sad how oblivious they are... destroying the purpose of the achievement list.

Hedge4 commented 2 months ago

My achievement total has been incorrect (+2) for so long, and it was due to having crossed off "Semnai Sans Shadow" and "Deianeira of Snezhevna" twice. It's been over 10 months, is there any roadmap on when this will be fixed?

I might look into creating a PR myself if that's appreciated. I'm assuming just removing the achievements creates conflicts, but can't we just add "Discarded" to each one like "Secret Miracle (Discarded)"? Or "Removed"?

WMGameLive commented 2 months ago

My achievement total has been incorrect (+2) for so long, and it was due to having crossed off "Semnai Sans Shadow" and "Deianeira of Snezhevna" twice. It's been over 10 months, is there any roadmap on when this will be fixed?

I might look into creating a PR myself if that's appreciated. I'm assuming just removing the achievements creates conflicts, but can't we just add "Discarded" to each one like "Secret Miracle (Discarded)"? Or "Removed"?

This site is dead already, pr is useless.

Reelix commented 2 months ago

This site is dead already, pr is useless.

Yet it has the Natlan achievements. Very odd for a dead site ;p

HonkySora commented 2 months ago

The site has been in auto mode for a while now. While sure, it has the achievements for Natlan, it doesn't mean the site is actively being worked on (see the other bugs that are not addressed, like the missing Hydro Traveler in the character tracker). I will wager when the game adds junk achievements in its files, it will be added to the list without any QA.

It hurts to say as a long-time user of the site, but we have to search for alternative tracker sites now if we want the accuracy on the list. Genshin Center has both an Ascension Planner and an Achievement Tracker. Recently, stardb.gg has also added Genshin-related features, with both Achievement and Wish trackers available.

N1klot commented 2 months ago

I made a switch to seelie.me a long time ago. At this point even if they fixed their shit im not going back, waited way too long for them to fix

Hedge4 commented 2 months ago

The site has been in auto mode for a while now.

I'm not sure what that's supposed to mean, but @MadeBaruna made 7 commits today that though routine, look like they required quite a bit of manual labour. I just want to know if it'd be accepted if I make a PR (that just changes the names).

I'm guessing nothing is being done about it because a proper fix takes a lot more effort, since even if you just remove the dead achievements they're still in users' save files and I'm assuming there's no handling for deleted achievements yet.

Hedge4 commented 2 months ago

I think I found what function could be changed to handle old savefiles, it turns out something similar was done to move the achievements from "Memories of the Heart" to their own category once removed from "Wonders of the World".

It's migrateNewVersion() in paimon-moe/src/routes/achievement/index.svelte, lines 294-323.

I'm somewhat sure those 6 achievements can just be removed from the files after adding this code block:

const deprecatedIds = [
  81416, 81418, 81426, 81429, 81451, 
  81453
];

if (checkList['0']) {
  for (const item of deprecatedIds) {
    if (checkList['0'][item] === true) {
      delete checkList['0'][item];
    }
  }
}

Ids to be removed:

Deses commented 2 months ago

The site has been in auto mode for a while now. While sure, it has the achievements for Natlan, it doesn't mean the site is actively being worked on (see the other bugs that are not addressed, like the missing Hydro Traveler in the character tracker). I will wager when the game adds junk achievements in its files, it will be added to the list without any QA. It hurts to say as a long-time user of the site, but we have to search for alternative tracker sites now if we want the accuracy on the list. Genshin Center has both an Ascension Planner and an Achievement Tracker. Recently, stardb.gg has also added Genshin-related features, with both Achievement and Wish trackers available.

Is there any "competing" site that can import Paimon.moe's wish history?

HonkySora commented 2 months ago

I'm personally using stardb.gg now that they've added the feature recently (also updated to be able to import from Paimon.moe). One other tracker is from hotgames.gg, same guys who made the community Interactive Map although I haven't tried it yet (it doesn't seem to have an easy way to import data from third-party sites)

Deses commented 2 months ago

stardb.gg is looking very good! I can have all 3 games into one good looking website. Nice!