MadeBaruna / pom-moe

Mozilla Public License 2.0
86 stars 10 forks source link

incorrect import #6

Open WhiteNivis opened 1 year ago

WhiteNivis commented 1 year ago

Good day. Thank you for the site. Faced the problem of incorrect import. Screenshots below.

2023-06-17_17-12-43 2023-06-17_17-12-05 2023-06-17_17-09-41

Jhazor commented 1 year ago

i can add to this the import seems to have started adding 1 to the pity count image counting from "Hook." the "Herta" and "Make the World Clamor" are correct - and we can see the "Bailu" matches the pull count image but when we count from "Make the World Clamor" onwards "Asta" shows 10 when it should be 9 and "Good Night and Sleep Well" shows an 11 which should be impossible but its clear that the relevant pulls were 108 and 118 and thus the total should be 10 so it would appear the bug has been introduced sometime after the 4th

southrop commented 1 year ago

I think this bug might not be due to a particular update. I didn't discover this site until recently and upon importing my wish history, it was correct up until a certain point. You cans see from my history that my pity counts were correct up until the "Under the Blue Sky", where it started to exhibit the +1 noted by Jhazor. image

Comparison with SRS (added some lines to help match up because line height is different) image

Also not sure if this is related, but some of my current pity counts are all +1 from what SRS shows me. Some of the pity counts in WhiteNivis' screenshots also show this issue. Weirdly, it's not every count; only some of them. Pom image SRS image

Jhazor commented 1 year ago

following Southrop's discovery i fiddled about some more i cleaned out my browser for the site and did a fresh import and noticed this image this is the same section from my previous comment "make the world clamour" to "good night and sleep well" but as you can see its all correct. however this was all imported cleanly in one go via the powershell script method - the same happened when i used the Webcache Data_2 file clean import no +1 increment - now I usually use the powershell script but I remember one time I tried the data_2 file method just to try it out - I think maybe the +1 increment might be being caused by mixing import types.

southrop commented 1 year ago

I've been using the data_2 method the whole time, so I don't think it's an issue of mixing. it could be due to multiple imports not being correctly appended or something. I deleted my history and tried reimporting it all in one go with the data_2 method as a test and the numbers are correct now. image image