search

MadeInHaus / react-starter

A client-side SPA starter bundled with React, Redux, CSS Modules, React Router 4, and Webpack 4
MIT License
9 stars 2 forks source link

Precommits run inside node (web) container #30

Closed rynocouse closed 6 years ago

rynocouse commented 6 years ago

Run lint-staged inside node container

chrisjcodes commented 6 years ago

We should also consider that if we force docker in development are we breaking our one-to-one if we end up deploying the app as a static in production? We currently have an issue open to implement static builds, #11. Is that no longer valid after this merge?

stevescavo commented 6 years ago

We should also consider that if we force docker in development are we breaking our one-to-one if we end up deploying the app as a static in production?

@unruffledBeaver no, our approach for generating static sites in production should be separate from running Docker locally.

chrisjcodes commented 6 years ago

@stevescavo I guess my point here is if we are building the site to be deployed in production statically, wouldnt it be better not to build it inside node locally? Maybe its not a huge deal but I feel like docker should be easy to remove all together if we know the app is going to be static and those who might want to use the starter that arent using our pipeline can dev and build a static app

chrisjcodes commented 6 years ago

After discussing this with @rynocouse I changed my mind from my last comment and I see the advantage of always running docker for development, even if the site wont be deployed into a container. Mostly that any package that builds against a node target, like Node-Sass, will rely on local node instances which could vary from host to host without freezing the version in docker.