MadeInHaus / react-starter

A client-side SPA starter bundled with React, Redux, CSS Modules, React Router 4, and Webpack 4
MIT License
9 stars 2 forks source link

Reorganize directory structure #35

Closed stevescavo closed 6 years ago

stevescavo commented 6 years ago
chrisjcodes commented 6 years ago

We should throw Bundle into containers. containers can house utilities and shared business logic components like Scroll, withSomeData HOC, etc

stevescavo commented 6 years ago

@unruffledBeaver I'm gonna do that.

rynocouse commented 6 years ago

Wait, since we're on this we should pull out magic imports

stevescavo commented 6 years ago

@rynocouse I think that should be a separate PR pinned against issue #25

chrisjcodes commented 6 years ago

Agree, without atomic not much reason for it. Also can convert jsx to js

stevescavo commented 6 years ago

@unruffledBeaver @rynocouse https://github.com/MadeInHaus/react-redux-webpack-starter/pull/35/commits/8236770a1c1cae644335a6d4af9cdc16cd6e03bc

stevescavo commented 6 years ago

If we're all good on this, I'd like to merge :)