Crypto Missing

[yovanoc]

Il n'y a pas du tout la partie crypto dans les keys proposées, est-ce normal ?

[MadeInPierre]

Hello ! Je n'ai pas encore de cryptos donc aucun moyen de voir ce que retourne l'API pour l'ajouter :shrug: De manière générale, ma méthode est d'avancer sur les features en fonction de mon portefeuille (qui aura bien des cryptos un jour ou l'autre) en essayant de garder une approche extensible. J'accepte avec plaisir toutes contributions pour étendre ce projet pour le faire marcher avec vos situations !

• Exemple #24

N'hésite pas si tu aimerais que je t'explique comment ajouter les cryptos, l'inspiration peut démarrer ici :slightly_smiling_face:

[yovanoc]

Ok, I never done python coding but can try. How can we launch the examples/demo script to use the current state of the code? when I try to launch it that way it gives me this:

and that's what I tried

[MadeInPierre]

Weird, the project should be stable. The latest version uses global imports (without dots, meaning finalynx must be installed globally in order to work properly):

Some ideas:

• Is the repo up to date? Maybe do a git pull just in case?
• Are you using Python version 3.8 or later?
• Have you installed the project in editable mode? Use pip install -e . at the root of the repo, which is equivalent to pip install finalynx but it using the local repo.
• Have you installed all dependencies using poetry install?

You should be able to simply run the demo without any code change:

python examples/demo.py

Let me know if that helps! Maybe the initial setup tutorial could be useful too. Let's try to setup your local project first, and then I'll try to give you my best advice on where to start to add cryptos. If the setup tutorial isn't clear enough, I'd be happy to explain it further (Python is awesome but it can be confusing sometimes ^^)

[yovanoc]

Ok mb I didn't know the pip install -e . to install it from the project and allow me to modify it and test.

I've started the crypto part and I think I will open a PR today. thanks

Just, I really need to do a pr to the finary_api repo to have this or I can access it other way?

because when I do this in this repo:

it is not available but doing this thing make it work

[MadeInPierre]

Great!

I'll take a look in a moment, ideally you shouldn't need to modify finary_api but I've never tried using cryptos. Be right back!

EDIT: Also, I heavily modified finary_fetch.py yesterday to fix #41, please make sure you are up to date to avoid conflicts

[yovanoc]

Yeah already updated it. Don't worry for git things I'm a pro' developer, just never coded in Python 😂

[MadeInPierre]

Got it sorry x) You'll teach me one day then :stuck_out_tongue:

Several options:

1. Make a PR in finary_api with what you suggested, looks like the author forgot it or isn't using it in command-line (__main__.py is called when you do python -m mypackage).
2. Specify the location of the method by using:

   import finary_api.user_portfolio
   ...
   finary_api.user_portfolio.get_portfolio_cryptos(session)

3. Looks like this method only has one line, simply use the shortcut directly (get_portfolio is available in __main__):

   ff.get_portfolio(session, "cryptos")

EDIT: Forget about the 3rd option, looks like there's another method with the same name that does something different, so option 2 is fine.

[yovanoc]

Got it sorry x) You'll teach me one day then 😛

What do you mean? I didn't want to be rude saying that.

Otherwise, thank you option 2 is good !

[MadeInPierre]

Sure no worries! I simply meant I'd be happy to learn from you since this is literally my first public repo, there's surely plenty of stuff to improve here and I'd love to know about it ^^