search

MadeMyDay / PageTableExtended

Extends the Processwire PageTable field for rendering table row layouts.
15 stars 11 forks source link

Support custom template- and rendering-engines #2

Closed felixwahner closed 10 years ago

felixwahner commented 10 years ago

Hi Marc, I've made some minor changes to let your module support custom rendering engines and template extensions: In our case we're using the existing "$config->templateExtension" and set it to ".twig" (which wasn't supported by your module as you've hardcoded .php as the templates extension). Furthermore I've changed the $parsedTemplate->render() call to render the page instead of just the template file as most modules hook to PageRender::renderPage to alter the templates output. Maybe this should be made configurable (for people using the "delegate approach")?

MadeMyDay commented 10 years ago

Hi Felix, danke :-)

Maybe this should be made configurable (for people using the "delegate approach")?

Does it make sense to make it configurable? Or isn't the result the same with your changes, no matter if people use a delegated approach or not?