Open MichaelJHaywood opened 1 year ago
The problem seems to be here:
action.ts
if (prNumber != null && !skip) {
If the prNumber is undefined we don't add a comment. In the case of a "push" there is no prNumber set.
I've managed to get this working by getting the PR number associated with the commit.
case 'push':
base = github.context.payload.before
head = github.context.payload.after
const prs: any[] = (await client.rest.repos.listPullRequestsAssociatedWithCommit({
commit_sha: github.context.sha,
owner: github.context.repo.owner,
repo: github.context.repo.repo,
})).data
if(prs.length > 0){
prNumber = prs[0].number
}
break
Overall this means pushing changes will not update the code coverage comment without this change (or similar).
@thsaravana Can you reopen issue and apply this fix on master branch?
I am already making some changes in 1.7 in this area. So I will test this as well and will fix this in 1.7 properly.
isn't the workaround also to trigger the workflow not on push
event, but on pull_request
opened
/ reopened
/ synchronize
? I think a push in a branch for which there's a PR always generates a synchronize
. and you would not want the action to run on a push
if there's no PR associated to the branch, right ?
isn't the workaround also to trigger the workflow not on
push
event, but onpull_request
opened
/reopened
/synchronize
? I think a push in a branch for which there's a PR always generates asynchronize
. and you would not want the action to run on apush
if there's no PR associated to the branch, right ?
The problem with that is that you always want to build and test on push, at least in main. Adding a comment to an associated PR is an optional addition. I wouldn't want to rebuild/retest everything just for the coverage comment.
Is there still any progress on this?
Same problem here, my workflows are triggered by push
and I don't want to have to re-build everything in a workflow with a pull_request
trigger. Would it be possible to either allow a PR number as an input or to try to get the PR number on push
workflows too? It should be possible
I've been having trouble trying to get the plugin to add a comment to the PR. I've enabled
debug-mode
and it successfully finds the Jacoco xml file. It outputs messages about the changes but doesn't mention trying to add a comment. The action is successful.Logs
I can successfully add comments myself using a separate github action so I don't believe this is permission related.
Adds a comment successfully
Am I using this incorrectly? Should it fail if it doesn't add a comment?