search

MadryLab / robustness

A library for experimenting with, training and evaluating neural networks, with a focus on adversarial robustness.
MIT License
903 stars 181 forks source link

store overwritten in example in docs #99

Open kaustubhsridhar opened 3 years ago

kaustubhsridhar commented 3 years ago

Hey, The robustness library is pretty amazing. :) I found a tiny error in your documentation for using robustness as a training library. (link)

The line 'store = store.Store(args.out_dir, args.exp_name)' overrides the name 'store'. This leads to an issue two lines later in 'schema = store.schema_from_dict(args_dict)' where the object store doesn't have a function called schema_from_dict but the library does.

Using cox.store.schema_from_dict fixes this issue.

Thanks