MadryLab / trak

A fast, effective data attribution method for neural networks in PyTorch
https://trak.csail.mit.edu/
MIT License
180 stars 26 forks source link

FAILED tests/test_rademacher.py::test_odd - AssertionError: Expected <True>, but was not. #23

Closed xszheng2020 closed 1 year ago

xszheng2020 commented 1 year ago

Hi, @kristian-georgiev thanks for your great work.

I installed traker by pip install traker[fast] under PyTorch 1.13.1 And then I tested python -m pytest -sv tests/test_rademacher.py It shows

FAILED tests/test_rademacher.py::test_odd - AssertionError: Expected <True>, but was not.
1 failed, 14 passed, 4 warnings in 3.10s

Any idea?

kristian-georgiev commented 1 year ago

I think this issue has the same root cause as https://github.com/MadryLab/trak/issues/24, addressing it there.