search

MadryLab / trak

A fast, effective data attribution method for neural networks in PyTorch
https://trak.csail.mit.edu/
MIT License
180 stars 25 forks source link

TRAK and fast-jl use deprecated `setup.py install` method #70

Open BrunoKM opened 3 months ago

BrunoKM commented 3 months ago

Installig fast-jl with Python 3.11 and setuptools==65.5.0 gives:

> pip install fast-jl
...
  DEPRECATION: fast-jl is being installed using the legacy 'setup.py install' method, because it does not have a 'pyproject.toml' and the 'wheel' package is not installed. pip 23.1 will enforce this behaviour change. A possible replacement is to enable the '--use-pep517' option. Discussion can be found at https://github.com/pypa/pip/issues/8559

This could be linked to the issues with installing traker[fast] and fast-jl with pip>=23 in #69

kristian-georgiev commented 2 months ago

The blocker for this is that fast_jl is a torch cpp_extension which afaik only supports setup.py :/ (see, e.g., https://pytorch.org/docs/stable/cpp_extension.html). If you know a way around this, that would be great.