MadsBuus / gedit-snapopen-plugin

Snapopen plugin for Gedit (Linux/Mac)
58 stars 18 forks source link

Improvements to Snapopen #7

Closed sbbowers closed 13 years ago

sbbowers commented 13 years ago

Hello Mads, I've made some changes to snapopen and I'm finding I'm liking it a lot better. Take a look at my changes and see if you want to promote them.

Scott Bowers.

Changelog:

Removed some of the performance band-aids in favor of a more straight forward solution; added small upgrades and bugfixes.

MadsBuus commented 13 years ago

Thanks, I like your changes. Let me try it out, since it is much more in tune with where I wanted to go than just crimppling the functionality to improve performance. I haven't had that much time lately so I've merged in some stuff without proper cleanup.

I as actually considering using updatedb/locate and store and search temp caches of project files. That is also extremely fast, but grep on a file list might work pretty well too!

Thanks for sorting out the glade bug. I was aware of it.

I was actually pretty fond of the 'search in full path' compared to jsut the file name, since I do a lot of rails development which has a pretty strict folder structure. In that way searching for 'model' will show you all models (even though none on the files a called 'model').

I'll get back to you. Thanks,

Mads

MadsBuus commented 13 years ago

Hi Scott,

I really like the code. It is much cleaner is several places. Somewhere along the way I think the multipattern stuff is broken, at least on this machine (a Mac). It has to do with differences in the way grep/find works. Grep uses a simple regex syntax, so with the pattern 'sn_gl' find finds it, but grep does not. For grep to find it, it sould be something like 'sn._gl'. I'll merge your changes and add a few lines.

MadsBuus commented 13 years ago

Done.