Null comparison with operator throws NullReferenceException

[JFReni]

Temperature? temperature = GetTemperatureFromMethodThatCouldReturnNull();

if(temperature == null)
{
   ...
}

The null comparison in the if statement throws because it uses the overloaded == operator for BaseUnit vs BaseUnit which calls:

if (left.Unit != right.Unit)

When right is null such as the comparison above this throws a NullReferenceException.

[MadsKirkFoged]

Hi JFReni

Thank you for reporting this bug! I have fixed it however it is not recommended in C# to use == as nullcheck. Instead use the is null or is not null

Temperature temperature2 = null;

//Not recommended!
if (temperature2 == null)
{                
}

//Recommended!
if (temperature2 is null)
{
}

//Recommended!
if (temperature2 is not null)
{
}