MadsKirkFoged / EngineeringUnits

Working with units made easy with automatic unit-check and converting between units

MIT License

41 stars 10 forks source link

Adding more cost-related units and cleaning up #41

Closed mschmitz2 closed 7 months ago

mschmitz2 commented 7 months ago

39

mschmitz2 commented 7 months ago

@MadsKirkFoged I only meant to add the first 4 commits to this pull request. Didn't think the others would show up in here after I created the pull request. I guess next time I'll create a specific branch for each pull request... In any case, the last 3 commits are just cleaning up some of the namespaces with no other changes, so feel free to add these changes as well or ignore them

MadsKirkFoged commented 7 months ago

Good job Max! And nice with the cleanup

mschmitz2 commented 7 months ago

Yeah no worries.. could eventually do the same kind of cleanup for all combined units, but I restrained myself.. for now. In any case, I'll be happy to contribute more to this is the future

MadsKirkFoged commented 7 months ago

Feel free to do as much cleanup as you want! Also if you find other places in the code you think needs a refactoring.

I would one day love to get a better structure in the Unittest project. Right now they are all just shoveled in.