DEV-12-shuttle-bus - Githubissues

MaelSemler / mini-cap

This is the Mini-Cap project for SOEN 390

3 stars 1 forks source link

DEV-12-shuttle-bus #184

Closed daphneaugier closed 4 years ago

daphneaugier commented 4 years ago

The shuttle bus path is available under the radio button of the bus as it is considered as a kind of public transport. Its path is drawn in red like the other alternate paths when the alternate option is clicked. We can select it in the list of paths, it is displayed as followed :

HOWEVER I was running out of resources and time to figure out how to make the shuttle bus time-aware. Even if I inputted the schedules of the shuttle bus into a .xml file, I couldn't not find a way to retrieve the different times.

daphneaugier commented 4 years ago

From the requirements list for meeting it says :

2.f) Support for the Concordia Shuttle Service (time-aware and location-aware)

daphneaugier commented 4 years ago

The ChangeDestinationTest appears to be failing for me. The problem seems to originate from the Directions fragment. Could you double check if the tests are working on your side?

This test passes on my computer :

Andynism commented 4 years ago

There's a problem with the geocoder being used in the Directions fragment on my end, so I'll withdraw my review for now.

johnstonstott commented 4 years ago

I am able to get the same as your screenshot, please resolve the conflicts so I can rereview

johnstonstott commented 4 years ago

Are you sure you pulled submaster with all the other PRs merged? There are some things that were patched today that are no longer working on your branch

System tests that @yabdelkawy did
Calendar to outdoor directions that @lposo did

Update: This appears to have been an issue on my side, apologies