Maescool / Catacomb-Snatch

Mojang's Humble bundle source
Other
295 stars 99 forks source link

Bug in pull #879 #881

Closed KBaluh closed 12 years ago

KBaluh commented 12 years ago

Moved down the screen. The lower part appears at the top.

To fix bugg need comment string System.setProperty("sun.java2d.opengl", "True"); or change System.setProperty("sun.java2d.opengl", "False");

WIndow 7 x32

master-lincoln commented 12 years ago

This seems to be an issue with your system. On other machines this increases the framerate a lot. We could add an option for it though...

KBaluh commented 12 years ago

https://docs.google.com/file/d/0ByApJdzcfxqMZ01NZ1lIbklTQVd4VDNGTmlqTTFHUQ/edit

KBaluh commented 12 years ago

Maybe create options to enable or disable driver?

joeyismusic commented 12 years ago

If someone just writes a simple back buffer flipper, you can solve a lot of problems. Basically all you need to do is create an off screen image using the canvas, and then if opengl is enabled, render all drawing operations to that off screen image and then draw that image to screen. if opengl is not enabled, render everything to the buffer strategy.

master-lincoln commented 12 years ago

I added an option. By default it's disabled now. 1bb4d9f32f3f9bb00f64b6cdf1582aac2c133473

KBaluh commented 12 years ago

Good, its work.

danielduner commented 12 years ago

We should try to figure out the root problem. It is better if we can make the game function in the best possible way, without requiring any input from the user (like selecting options)

Stuessy commented 12 years ago

@danielduner I totally agree on that, but I think it's an good enough compromise for now having it optional.

master-lincoln commented 12 years ago

Yes we should. BUT opengl doubles fps on some computers. The error shown doesn't seem to be present everywhere (need more feedback). Sometimes it's just impossible to select the best settings for a user. Especially when it comes to hardware acceleration stuff. We could just remove the option and leave some users with their slow laggy game instead...Or keep opengl and leave this poor Windows user alone with his problems.. It will need some time until we get a new graphics backend.

KBaluh commented 12 years ago

My graphics card - radeon. I think if OS Linux set OpenGL true, and if video card nvidia too.

danielduner commented 12 years ago

@master-lincoln I agree that an option is better than nothing. I'm just saying that we need an open issue for this, to keep working on it.