Level.getEntities refactored and fixed some spawner related bugs

olilo commented 12 years ago

Hey you all.

I am new to this project, but I saw the Mojam live. I began muddling around in the source code on my own after Mojang released it, without knowing that you already built up this github project. It has come along really nice I must say - you have done a great deal of work here :).

So here is the little I have done in the short time:

A bit of refactoring in the Level (to eliminate duplicate code and reduce the cyclomatic complexity a bit ... but it will still be a lot of work until it's below 100).
(hopefully) fixed issue #823: Spawner should not be placed on treasure chest or under turret
added IntelliJ Idea configs (if you don't like them, then I can take them out of this pull request)

So, I hope you'll find it useful and that I may provide more changes in the future.

Maescool commented 12 years ago

Hi @olilo thanks for the refactor, looks good to me No problem if you add an extra IDE, i don't mind for extra support, makes it easier on the people who start with this project, to use their own favored IDE, but it's strange nobody yet gave vim or emacs profiles (evil ancient war ;))

is this one ok for the rest? no answer after couple of days is auto merge by me :)

Flafla2 commented 12 years ago

I'm okay with it. +1

Maescool / Catacomb-Snatch

Level.getEntities refactored and fixed some spawner related bugs #904