search

Maescool / Catacomb-Snatch

Mojang's Humble bundle source
Other
295 stars 99 forks source link

Changed coin life to be difficulty dependent #918

Closed Tipaa closed 12 years ago

Tipaa commented 12 years ago

As per #569

Coins now have a less random life that is affected by difficulty.

Maescool commented 12 years ago

won't this break MP? (can somebody test?)

Tipaa commented 12 years ago

It shouldn't do - TitleMenu.difficulty is what most other things use - Level, GameMode, ShopItem - all it does is remove a random call and increase the times to be easier on lower difficulties.

Maescool commented 12 years ago

i meant client side, since the host defines difficulty.. or did i miss the code that when you join that value is set?

andy36 commented 12 years ago

I would also say to use ordinal() only as a last resort. For this, you can just add a "coin life" modifier or number to the enum of difficulties.

Tipaa commented 12 years ago

I have added coin lifespan to the enum.

TitleMenu.difficulty is set in Network.java line 142: TitleMenu.difficulty = DifficultyInformation.getByInt(sgMessage.difficulty);

Pushing now.

Maescool commented 12 years ago

ok, my bad :) uhm, anyone else a comment? or can it be merged? :)