search

MaestroError / php-heic-to-jpg

The easiest way to convert HEIC images to JPEG with PHP and Laravel framework
MIT License
148 stars 20 forks source link

Actually fixed temporary file not deleted issue as well as missing binary execute permission issue #40

Closed jdevinemt closed 8 months ago

jdevinemt commented 8 months ago

I submitted #39 to fix an issue with a temporary file not getting deleted on conversion failure in certain cases. I must have merged the wrong branch from my fork, because it didn't include the commit with the actual bug fix 😓 That commit is included here.

I also included a fix for #28 by adding the execute permission to the binary used for converting on linux-arm-64 architectures.

The composer.json change is just because one of the commits I meant to merge in the last PR set the required version of PHP. The package author made this change in a separate commit. When I merged that change there was just a difference of no newline at the end of the file.

Sorry I missed those commits on the last PR. That was only my second PR for a public repo 😅

MaestroError commented 8 months ago

@jdevinemt Here is a new release for you 👍

https://github.com/MaestroError/php-heic-to-jpg/releases/tag/v1.0.7

jdevinemt commented 8 months ago

@MaestroError Thanks so much!