Maetrim / DDOBuilder

Maetrims DDO character Planner. Uses XML file formats
88 stars 31 forks source link

Some Favored weapon bonuses are still broken with latest version. #749

Open YoureNotDead opened 9 months ago

YoureNotDead commented 9 months ago

Any favored weapon bonuses calling for <stance>FavoredWeapon</stance> will not pull correctly and need to be updated to <stance>Favored Weapon</stance> or<anyofstance>Favored Weapon</anyofstance> to apply correctly. Tested using Cleric War Priest tree. Attached image shows current builder version and that I am in favored weapon stance but not getting any of the bonuses to attack/damage stats as they are marked as inactive due to pulling a stance that is not referenced. image

YoureNotDead commented 9 months ago

If you would like i could go through and update all of them on my side and share the files that have fixes in them so that you may use them in the next update

YoureNotDead commented 9 months ago

Looking into this issue more, the new update breaks this fix method. When using a good stance pull you are now always put into favored weapon stance. In this image I have great swords as a favored weapon but when swapping to any other weapon with the fixed stance pulls applied, I continue to stay in favored weapon stance and get the favored weapon buffs. image

GrayGeorge commented 6 months ago

this bug happens because the FavoredWeapon stance works ONLY if you have 10 or more levels of Favored Soul. not exactly sure why the check was added in the first place, but it breaks the stance for every other class, as well as any FvS multiclass with less than 10 levels in it ss+(2024-05-24+at+01 15 56)