search

MagLev / maglev

GemStone Maglev Ruby Repository
http://maglev.github.io
517 stars 41 forks source link

Working MagLev Darwin parser #405

Closed johnnyt closed 9 years ago

johnnyt commented 9 years ago

@zenspider and @AllenOtis - I was able to get this to work by removing the -Werror param from CCWARN.

It seems like there should be a better way to do this - thoughts?

AllenOtis commented 9 years ago

We need to understand what the error was and fix the C source code so -Werror can still be used. There are differences in "lint" errors from different versions of gcc ... Let's look at this during the hacking meeting. Allen

On Tue, Jul 7, 2015 at 4:17 PM, JohnnyT notifications@github.com wrote:

@zenspider https://github.com/zenspider and @AllenOtis https://github.com/AllenOtis - I was able to get this to work by removing the -Werror param from CCWARN.

It seems like there should be a better way to do this - thoughts?

You can view, comment on, or merge this pull request online at:

https://github.com/MagLev/maglev/pull/405 Commit Summary

  • Add comments in prim failure path.
  • Fix lint complaints on Darwin
  • Fix to check all malloc calls for NULL result.
  • call LrgNegate_ instead of LrgNegate for more error checking in VM.
  • Fix lint complaints on Darwin by using intptr_t
  • Fix symbol import/export problems between libgcilnk and libmagparse on
  • Releasing MagLev-1.2Alpha6 with 36816
  • Merge pull request #404 from MagLev/update-to-36816
  • :no_entry_sign: Ignores libmagparse.*
  • Removes -Werror from CWARN to fix Darwin compile error

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/MagLev/maglev/pull/405.

johnnyt commented 9 years ago

@AllenOtis - removing those lines did the trick.

I think this is ready to merge.

AllenOtis commented 9 years ago

Go ahead and do the merge then.

On Wed, Jul 8, 2015 at 6:21 AM, JohnnyT notifications@github.com wrote:

@AllenOtis https://github.com/AllenOtis - removing those lines did the trick.

I think this is ready to merge.

— Reply to this email directly or view it on GitHub https://github.com/MagLev/maglev/pull/405#issuecomment-119576336.

johnnyt commented 9 years ago

Closes #402