Closed johnnyt closed 8 years ago
The base server doesn't use STONEHOST . I general I would prefer command line args where feasible. Otherwise I would suggest environment variables should be preceeded with MAGLEV to try to avoid collision with other environment vars not related to Maglev.
On Tue, Aug 18, 2015 at 1:40 PM, JohnnyT notifications@github.com wrote:
Closes #435 https://github.com/MagLev/maglev/issues/435
@AllenOtis https://github.com/AllenOtis or @dalehenrich https://github.com/dalehenrich - do you see any issues with this
addition (using the value of $STONEHOST by default)?
You can view, comment on, or merge this pull request online at:
https://github.com/MagLev/maglev/pull/436 Commit Summary
- Uses STONEHOST env var if available
File Changes
- M bin/maglev-ruby https://github.com/MagLev/maglev/pull/436/files#diff-0 (2)
Patch Links:
— Reply to this email directly or view it on GitHub https://github.com/MagLev/maglev/pull/436.
Allrighty - I changed it to use MAGLEV_STONEHOST instead of STONEHOST
Closes #435
@AllenOtis or @dalehenrich - do you see any issues with this addition (using the value of $STONEHOST by default)?