Delete message doesn't show slide or slider title

[Franciscof-Serfe]

When you delete a slide from the backend, the message does not show the title of the slide that is being deleted.

FIX: Slide:

diff --git a/app/code/Mageants/BannerSlider/Ui/Component/Listing/Column/SlidesActions.php b/app/code/Mageants/BannerSlider/Ui/Component/Listing/Column/SlidesActions.php
index 9da2bbfc1..8b533f8bf 100755
--- a/app/code/Mageants/BannerSlider/Ui/Component/Listing/Column/SlidesActions.php
+++ b/app/code/Mageants/BannerSlider/Ui/Component/Listing/Column/SlidesActions.php
@@ -85,8 +85,8 @@ class SlidesActions extends \Magento\Ui\Component\Listing\Columns\Column
                             ),
                             'label' => __('Delete'),
                             'confirm' => [
-                                'title' => __('Delete "${ $.$data.title }"'),
-                                'message' => __('Are you sure you wan\'t to delete the Slide "${ $.$data.title }" ?')
+                                'title' => __('Delete "' . $item['title'] . '"'),
+                                'message' => __('Are you sure you want to delete the slide "' . $item['title'] . '"?')
                             ]
                         ]
                     ];

Slider:

`diff --git a/app/code/Mageants/BannerSlider/Ui/Component/Listing/Column/SlidersActions.php b/app/code/Mageants/BannerSlider/Ui/Component/Listing/Column/SlidersActions.php
index d84d769b5..14b60ef43 100755
--- a/app/code/Mageants/BannerSlider/Ui/Component/Listing/Column/SlidersActions.php
+++ b/app/code/Mageants/BannerSlider/Ui/Component/Listing/Column/SlidersActions.php
@@ -85,8 +85,8 @@ class SlidersActions extends \Magento\Ui\Component\Listing\Columns\Column
                             ),
                             'label' => __('Delete'),
                             'confirm' => [
-                                'title' => __('Delete "${ $.$data.name }"'),
-                                'message' => __('Are you sure you wan\'t to delete the Slider "${ $.$data.label }" ?')
+                               'title' => __('Delete "' . $item['slider_name'] . '"'),
+                               'message' => __('Are you sure you want to delete the slide "' . $item['slider_name'] . '"?')
                             ]
                         ]
                     ];

` Mageants BannerSlider v2.1.0 in Magento 2.4.4-p2

[MageAnts]

Hello,

Did you purchased our extension?

Thanks

From: Francisco Fernandez @.*** Sent: Saturday, May 13, 2023 9:26 AM To: MageAnts/magento-2-banner-slider Cc: Subscribed Subject: [MageAnts/magento-2-banner-slider] Delete message doesn't show slide title (Issue #1)

When you delete a slide from the backend, the message does not show the title of the slide that is being deleted.

https://user-images.githubusercontent.com/115582581/238110921-943aa211-4cc9-458b-a853-8163b4aded99.png image

FIX:

diff --git a/app/code/Mageants/BannerSlider/Ui/Component/Listing/Column/SlidesActions.php b/app/code/Mageants/BannerSlider/Ui/Component/Listing/Column/SlidesActions.php index 9da2bbfc1..8b533f8bf 100755 --- a/app/code/Mageants/BannerSlider/Ui/Component/Listing/Column/SlidesActions.php +++ b/app/code/Mageants/BannerSlider/Ui/Component/Listing/Column/SlidesActions.php @@ -85,8 +85,8 @@ class SlidesActions extends \Magento\Ui\Component\Listing\Columns\Column ), 'label' => __('Delete'), 'confirm' => [

· 'title' => __('Delete "${ $.$data.title }"'),

· 'message' => __('Are you sure you wan\'t to delete the Slide "${ $.$data.title }" ?')

· 'title' => __('Delete "' . $item['title'] . '"'),

· 'message' => __('Are you sure you want to delete the slide "' . $item['title'] . '"?') · ] · ] · ];

— Reply to this email directly, view it on https://github.com/MageAnts/magento-2-banner-slider/issues/1 GitHub, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHFOQO7DWJYFGMIUUG6E5C3XF4A6FANCNFSM6AAAAAAYAHQMDI . You are receiving this because you are subscribed to this thread. https://github.com/notifications/beacon/AHFOQO3JMDTA2OZOCBKGFK3XF4A6FA5CNFSM6AAAAAAYAHQMDKWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHGLVDGLE.gif Message ID: @.***>

[Franciscof-Serfe]

Hi, nice to meet you

I have access to the module because we are the development team of customers who purchased your module.

So in the first message, I included the diff between the files and the version that we are working with that presented us with this issue. ** Mageants BannerSlider v2.1.0 in Magento 2.4.4-p2

In your example backend it doesn't play because you stopped displaying the name of the slide or slider.

With the fix:

I hope you find it useful

Regards, Francisco

[MageAnts]

Hello,

You need to share your purchase order number so we can verify it

Thanks in Advance

From: Francisco Fernandez @.*** Sent: Thursday, May 18, 2023 8:15 PM To: MageAnts/magento-2-banner-slider Cc: MageAnts - Robust Magento Extensions; Comment Subject: Re: [MageAnts/magento-2-banner-slider] Delete message doesn't show slide or slider title (Issue #1)

Hi, nice to meet you

I have access to the module because we are the development team of customers who purchased your module.

So in the first message, I included the diff between the files and the version that we are working with that presented us with this issue. ** Mageants BannerSlider v2.1.0 in Magento 2.4.4-p2

In your example backend it doesn't play because you stopped displaying the name of the slide or slider. https://user-images.githubusercontent.com/115582581/239262466-1107ae74-3745-46c6-91c8-1ee12af2830c.png Image removed by sender. image https://user-images.githubusercontent.com/115582581/239262586-21e18f88-5450-4348-adaa-53827a7ffcbd.png Image removed by sender. image

With the fix:

https://user-images.githubusercontent.com/115582581/239263788-5be6ebbb-457b-4f42-8f54-f6c81cc3277d.png Image removed by sender. image https://user-images.githubusercontent.com/115582581/239264484-7d8e9ecf-c404-435a-b07f-c126536f319f.png Image removed by sender. image

I hope you find it useful

Regards, Francisco

— Reply to this email directly, view https://github.com/MageAnts/magento-2-banner-slider/issues/1#issuecomment-1553172783 it on GitHub, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHFOQO7VOPHF6RZJ5TC4T6LXGYYVXANCNFSM6AAAAAAYAHQMDI . You are receiving this because you commented.Image removed by sender.Message ID: @.***>