search

MageSlayer / paludis-gentoo-patches

Unofficial Gentoo patches for Paludis package manager
GNU General Public License v2.0
14 stars 7 forks source link

Fix recursive doins behavior for paths with whitespace #41

Closed Ionic closed 1 year ago

Ionic commented 2 years ago

Target paths were not correctly quoted for recursive doins invocations, which lead to breakage.

A simple example would be "bar" -> "fo o", which would not have worked at all.

Fix this by quoting the files we're working with correctly, and add more extensive test cases for paths like these.

While at it, generally try to quote all unsafe components in doins.

Fixes: MageSlayer/paludis-gentoo-patches#40

This PR requires #37 to be merged first. Will undraft it as soon as that's the case.

Ionic commented 1 year ago

Rebased against the 2022 version of the eapi7 branch.

Ionic commented 1 year ago

Ugh, I accidentally rebased this against the eapi7 branch. This is supposed to go on the master branch first, then have it merged into the eapi7 branch later.

Ionic commented 1 year ago

Better. Will merge tomorrow.