MageTest / BehatMage

Behat for Magento
MIT License
85 stars 31 forks source link

Refactor Customer fixture #53

Closed walterdolce closed 10 years ago

walterdolce commented 10 years ago
jamescowie commented 10 years ago

Good work,

alistairstead commented 10 years ago

I don't like the service container being injected. This is a a close coupling to the container this is not the dependency inversion principle. There is now significant and inappropriate intimacy between the fixture class and the container. These collaborators should be injected at the constructor based on appropriate type hinted parameters. Please see my upcoming PR that includes and expanded service container definition that should form an example of the required changes.

tumblr_mszmqf3ssb1stn6klo1_500