search

MageTest / MageSpec

PHPSpec for Magento
MIT License
91 stars 24 forks source link

PHP Fatal error: Can't inherit abstract function PhpSpec\Locator\ResourceLocatorInterface::getPriority() #137

Closed elvetemedve closed 7 years ago

elvetemedve commented 8 years ago

I get the following error when I run specs:

PHP Fatal error: Can't inherit abstract function PhpSpec\Locator\ResourceLocatorInterface::getPriority() (previously declared abstract in MageTest\PhpSpec\MagentoExtension\Locator\Magento\AbstractResourceLocator) in /vagrant/vendor/inviqa/worldpay-module/vendor/magetest/magento-phpspec-extension/src/MageTest/PhpSpec/MagentoExtension/Locator/Magento/ModelLocator.php on line 37

Environment:

If I remove the abstract method declaration, it works. See https://github.com/MageTest/MageSpec/blob/develop/src/MageTest/PhpSpec/MagentoExtension/Locator/Magento/AbstractResourceLocator.php#L216-L219

maxbaldanza commented 7 years ago

@elvetemedve I think this may have been a bug in PHP see: https://bugs.php.net/bug.php?id=43200 Are you still having issues?

elvetemedve commented 7 years ago

I haven't used MageSpec recently, so I don't know. But it seems to be a PHP bug indeed.

maxbaldanza commented 7 years ago

I'll close this issue for now as mentioned it doesn't seem like an issue in Magespec. Feel free to open if it's still an issue