Magenerds / GermanLaw

This module provides general settings for german stores
http://doc.magenerds.com/germanlaw/
20 stars 21 forks source link

Duplicate rendering of tax and baseprice #21

Closed chequille closed 6 years ago

chequille commented 6 years ago

Hi, the fix you made is only working for simple products. Am using the latest release 1.0.13 and Magento 2.2.1

It is not working for configurable products. I get always Tax and Baseprice shown two times.

The second baseprice rendering is always taking the price from the parent product. grafik

Any idea why? BR Jürgen

hhusen commented 6 years ago

same problem for 2.1.10 (2.1.11) after update from 2.1.9

problem seems to be related to tier prices. Duplicate tax text after tier price block. same problem with baseprice, but probably out of scope of this issue.

Since 2.1.10 tier prices for configurable products seem to be rendered by javascript

example 1, variation no 55 (no tier prices):

55-v10

example 2: variation no. 35 (tier prices)

35-v10

tax text being rendered after tier block even if no tier price for the selected variation.

Until 2.1.9 tier prices had not been rendered on product page.

haelbichalex commented 6 years ago

same for me with Magento 2.2.2

bildschirmfoto 2018-01-30 um 11 43 40

Since I don't need tier prices I removed it in catalog_product_view.xml by adding <referenceBlock name="product.price.tier" remove="true" />

KlausGw commented 6 years ago

Hi, I need tier prices, but I don't want to show double Tax Info and baseprice. Is there a way to hide that? Magento 2.2.2

screenshot-2018-02-01-12-35-42

Best regards Klaus

TheSamsa commented 6 years ago

Should be fixed with: #24 Displays tax text either for final price or tier price, latter if there are tier prices defined.

hhusen commented 6 years ago

Fix #24 works for me (tax text). Thank you.

Eugenett commented 6 years ago

Hi there! May you tell please how versions of your extentions i need to install. I need BesePrice and GermanLaw. I was tried to install Full Package and got an error after install. Version of magento 2.1.11. How versions of release i need to check? Im waiting for your feedback. Thank you!

sydekumf commented 6 years ago

Did you install the latest release? https://github.com/Magenerds/GermanLaw/releases They should be compatible to 2.1.x

Eugenett commented 6 years ago

Yea, installing with GermanLaw was ok, witthout any problems. Installing with composer. But when i was tried to install BasePrice, i recieving problem like: [ReflectionException] Class Magento\Framework\Serialize\SerializerInterface does not exist. Latest release. Any solutions ? Thank you very much!

Eugenett commented 6 years ago

Heh, the problem is resolved. Like release guide, the last versions 1.2.0 and 1.2.1 supported magento 2.2.x. I have a problem with the Base Price. In fronted there is nothing behind empty white page. For resolving that issue was need delete all of Base Price records from DB. And reinstall module. Ok for now. Thank you!