search

Magenerds / GermanLaw

This module provides general settings for german stores
http://doc.magenerds.com/germanlaw/
20 stars 21 forks source link

not compatible with 2.2.2? #23

Closed Mlinnig closed 6 years ago

Mlinnig commented 6 years ago

I think the latest version of GermanLaw is not compatible with Magento 2.2.2 causing errors while installing:

Problem 1
    - Conclusion: don't install magenerds/module-germanlaw 1.0.3
    - Conclusion: don't install magenerds/module-germanlaw 1.0.3|remove magento/framework 101.0.2
    - Conclusion: don't install magenerds/module-germanlaw 1.0.3|don't install magento/framework 101.0.2
    - Installation request for magenerds/module-germanlaw 1.0.3 -> satisfiable by magenerds/module-germanlaw[1.0.3].
    - magenerds/module-germanlaw 1.0.3 requires magento/framework ^100.1 -> satisfiable by magento/framework[100.1.0, 100.1.1, 100.1.2, 100.1.3, 100.1.4, 100.1.5, 100.1.6, 100.1.7, 100.1.8, 100.1.9, 100.1.10, 100.1.11].
    - Can only install one of: magento/framework[101.0.2, 100.1.0].
    - Can only install one of: magento/framework[101.0.2, 100.1.1].
    - Can only install one of: magento/framework[101.0.2, 100.1.2].
    - Can only install one of: magento/framework[101.0.2, 100.1.3].
    - Can only install one of: magento/framework[101.0.2, 100.1.4].
    - Can only install one of: magento/framework[101.0.2, 100.1.5].
    - Can only install one of: magento/framework[101.0.2, 100.1.6].
    - Can only install one of: magento/framework[101.0.2, 100.1.7].
    - Can only install one of: magento/framework[101.0.2, 100.1.8].
    - Can only install one of: magento/framework[101.0.2, 100.1.9].
    - Can only install one of: magento/framework[101.0.2, 100.1.10].
    - Can only install one of: magento/framework[101.0.2, 100.1.11].
    - Installation request for magento/framework (locked at 101.0.2) -> satisfiable by magento/framework[101.0.2].

Maybe this fix could be implemented here as well? https://github.com/Nogrod/GermanLaw/commit/17c6cfd0c17eb1c5faeee3685a261df4d3c83b18

sean-nicholas commented 6 years ago

I don't know the difference between magenerds/germanlaw and magenerds/module-germanlaw. But the former seems to be more up to date. Try to install it instead.

sydekumf commented 6 years ago

Hi there, yeah sorry for this, seems like you use an old version. We changed the naming of it as you can see it here: https://github.com/Magenerds/GermanLaw/blob/master/composer.json#L2 I know, that wasn't the best decision we made as problems like yours occur, but we wanted to keep it consistent. Sorry for that :-) The latest version is compatible with Magento 2.2: https://github.com/Magenerds/GermanLaw/releases