search

Magenerds / PageDesigner

92 stars 41 forks source link

Fixes issue 22: put formElement at the correct place in the ui component .xml files. #25

Closed hostep closed 5 years ago

hostep commented 6 years ago

See: https://github.com/Magenerds/PageDesigner/issues/22

Watch out: I don't know anything about UI components, but looking a few lines higher in the file and I noticed that the formElement was declared differently. So changed it, and that fixed the issue apparently.

Problem only occurred in Magento 2.1.x, not in 2.2.x Tested fix in Magento 2.1.7, 2.1.14, 2.2.3 and 2.2.5 and seems to cause no problems in any of those versions.

sippsolutions commented 5 years ago

In M2.3 this triggers an exception:

(Magento\Framework\Exception\LocalizedException): The "formElement" configuration parameter is required for the "page-designer" field.

As it works perfectly in 2.2 and above, I'll close this PR.