search

MagerValp / AutoDMG

Create deployable system images from OS X installer
1.22k stars 117 forks source link

Fix installing packages on 10.15 #240

Closed tgoyne closed 1 year ago

tgoyne commented 5 years ago

When running on 10.15b9 I ran into several problems with installing packages into a system image that all seemed to be related to the default partitioning scheme created by the installer changing.

Mounting the disk image with hdiutil attach now gives the following output:

/dev/disk2              GUID_partition_scheme           
/dev/disk2s1            EFI                             
/dev/disk2s2            Apple_APFS                      
/dev/disk3              EF57347C-0000-11AA-AA11-0030654 
/dev/disk3s1            41504653-0000-11AA-AA11-0030654 /Volumes/Macintosh HD - Data
/dev/disk3s2            41504653-0000-11AA-AA11-0030654 /Volumes/Preboot
/dev/disk3s3            41504653-0000-11AA-AA11-0030654 /Volumes/Recovery
/dev/disk3s4            41504653-0000-11AA-AA11-0030654 /Volumes/VM
/dev/disk3s5            41504653-0000-11AA-AA11-0030654 /Volumes/Macintosh HD 1

The previous logic of egrep '/Volumes/' | head -1 picked "/Volumes/Macintosh HD - Data", but the path we actually want is "/Volumes/Macintosh HD 1" so I changed it to tail.

hdiutil info -plist does not include a image-alias field for any of the volumes, so dmgInfo["image-alias"] was throwing a KeyError and skipping every volume.

All of the volumes within the DMG now have a Role listed (Data, Preboot, Recovery, VM, System for the ones listed above), so hdiutilAttach_() would report no partitions found. We want to install to the partition with the System role, so I made it not exclude partitions with that role.

vasquesbc commented 5 years ago

I've tested AutoDMG including this fix and still getting the error described in https://github.com/MagerValp/AutoDMG/issues/238 May this be an localization issue? Since on a german sytem the "Macintosh HD - Data" Volume is named "Macintosh HD - Daten"

tgoyne commented 5 years ago

Is the order of the volumes the same? If it is then the names shouldn't matter. If it isn't then I think logic like what vfuse does would be needed, as the volume roles aren't localized.

osXCanada commented 4 years ago

I think imaging in this way on 10.15 is dead!

tgoyne commented 4 years ago

It's working fine for us, but we're using AutoDMG to build VM images rather than imaging physical machines.

osXCanada commented 4 years ago

Interesting!! But my point is imaging is dead as we know it…think more like iPad imaging…lay down the os, and let the mdm load the apps after.

What do you do with the VM images?

On Mar 4, 2020, at 11:46 AM, Thomas Goyne <notifications@github.com mailto:notifications@github.com> wrote:

It's working fine for us, but we're using AutoDMG to build VM images rather than imaging physical machines.